Skip to content

resolve zulip topic on issue priority assigned - #2491

Open
apiraino wants to merge 1 commit into
rust-lang:mainfrom
apiraino:resolve-zulip-topic-on-priority-assigned
Open

resolve zulip topic on issue priority assigned#2491
apiraino wants to merge 1 commit into
rust-lang:mainfrom
apiraino:resolve-zulip-topic-on-priority-assigned

Conversation

@apiraino

@apiraino apiraino commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Closes #2139

As per Zulip discussion.

This should resolve the Zulip topic when a regression has been assigned a priority label.

Note after a first test: if an issue is solved and then given again a I-prioritize label, a new zulip topic will be created (because the title of the old one has now a "✔ ".

@apiraino
apiraino force-pushed the resolve-zulip-topic-on-priority-assigned branch from 7d81055 to 75f1600 Compare August 31, 2026 15:27
@apiraino
apiraino marked this pull request as ready for review August 31, 2026 15:28
@apiraino

apiraino commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

r? @Urgau

(maybe? feel free to reroll if you don't have time)

@rust-lang rust-lang deleted a comment from rustbot Aug 31, 2026
@Urgau

Urgau commented Aug 31, 2026

Copy link
Copy Markdown
Member

@apiraino to assign someone from T-triagebot you can use r? triagebot

@Urgau

Urgau commented Aug 31, 2026

Copy link
Copy Markdown
Member

if an issue is solved and then given again a I-prioritize label, a new zulip topic will be created (because the title of the old one has now a "✔ ".

Hopefully this is not too much of an issue.

@Urgau Urgau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me. Only two small nits.

View changes since this review

Comment thread src/zulip/client.rs Outdated
Comment thread src/zulip/client.rs Outdated
Comment thread src/zulip.rs Outdated
@apiraino
apiraino force-pushed the resolve-zulip-topic-on-priority-assigned branch from 75f1600 to 3cbb099 Compare September 1, 2026 08:42
@apiraino

apiraino commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

thanks for the review

@apiraino
apiraino requested a review from Urgau September 1, 2026 08:42
@apiraino
apiraino enabled auto-merge September 1, 2026 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add an option to NotifyZulipLabelConfig to automatically resolve the zulip topic when the label is removed

2 participants